Adding variable for managing firewall ports

README.md

@@ -5,7 +5,7 @@ Ansible playbook that provisions a group of servers to run HAProxy with a shared
 ## Variables
 
 |             Variable              | Required |              Default              |    Choices    |                                                                               Description                                                                                |
-| --------------------------------- | -------- | ---------------------- | ------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
+| --------------------------------- | -------- | --------------------------------- | ------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
 | haproxy_bind_adapter              | Yes      | eth0                              |               | Interface to use for the Shared IP                                                                                                                                       |
 | haproxy_config_file               | Yes      | example.haproxy.cfg.j2            |               | File name to use for the haproxy config file                                                                                                                             |
 | haproxy_keepalived_adapter        | Yes      | eth0                              |               | Interface to use for the keepalived communication                                                                                                                        |
@@ -17,6 +17,7 @@ Ansible playbook that provisions a group of servers to run HAProxy with a shared
 | haproxy_shared_priority           | Yes      | 100                               |               | Keepalived priority for the host - this will                                                                                                                             |
 | haproxy_shared_state              | Yes      | MASTER                            | MASTER/BACKUP | What state the keepalived configuration will start with for the desired host - After config starts it will determine if other members exist and adjust based on priority |
 | haproxy_shared_virtual_router_id  | Yes      | 25                                |               | Virtual Router ID for the keepalived configuration - This should be the same for the group                                                                               |
+| haproxy_listen_ports              | Yes      | 22/tcp, 80/tcp, 443/tcp, 9999/tcp |               | The firewall ports/protocols that should be opened on the firewall                                                                                                       |
 
 ## Example
 

roles/haproxy/defaults/main.yml

@@ -9,6 +9,15 @@ haproxy_shared_ip: ""
 haproxy_shared_ip_subnet: "/24"
 haproxy_shared_virtual_router_id: 25
 haproxy_keepalived_process_weight: 10
+haproxy_listen_ports: 
+  - port : 22
+    protocol: tcp
+  - port : 80
+    protocol: tcp
+  - port : 443
+    protocol: tcp
+  - port : 9999
+    protocol: tcp
 
 # Set per host
 

roles/haproxy/tasks/main.yml

@@ -110,19 +110,7 @@
     permanent: yes
     immediate: yes
     state: enabled
-  with_items:
+  loop: "{{ haproxy_listen_ports }}"
-    - {port: "22", protocol: "tcp"}
-    - {port: "80", protocol: "tcp"}
-    - {port: "443", protocol: "tcp"}
-  notify: reload firewalld
-  become: yes
-
-- name: Enable firewall ports for haproxy stats
-  firewalld:
-    port: "9999/tcp"
-    permanent: yes
-    immediate: yes
-    state: enabled
   notify: reload firewalld
   become: yes