Cleaning up templates for dnf-automatic

roles/base/defaults/main.yml

@@ -102,6 +102,9 @@ base_redhat_epel: true
 # DNF Automatic
 # =============
 
+base_redhat_dnf_automatic_timer: "02:00"
+base_redhat_dnf_automatic_timer_randomizer: "5m"
+
 # commands
 # --------
 

roles/base/tasks/redhat_automatic_updates.yml

@@ -42,9 +42,18 @@
     recurse: yes
     state: directory
 
-- name: Deploy dnf-automatic install service override
+- name: Deploy dnf-automatic install service override (YUM versions)
   template:
-    src: "dnf-automatic-install.service-{{ ansible_distribution_major_version }}.j2"
+    src: "dnf-automatic-install.service-yum.j2"
     dest: /etc/systemd/system/dnf-automatic-install.service.d/override.conf
   become: true
   notify: Daemon Reload
+  when: ansible_distribution_major_version == 7
+
+- name: Deploy dnf-automatic install service override (DNF versions)
+  template:
+    src: "dnf-automatic-install.service-dnf.j2"
+    dest: /etc/systemd/system/dnf-automatic-install.service.d/override.conf
+  become: true
+  notify: Daemon Reload
+  when: ansible_distribution_major_version != 7

roles/base/templates/dnf-automatic-install.service-8.j2

@@ -1,2 +0,0 @@
-[Service]
-ExecStartPost=/bin/sh -ec 'dnf needs-restarting -r | grep -q "Reboot is req.*" && shutdown -r +5 Rebooting after applying package updates || exit 0'

roles/base/templates/dnf-automatic-install.service-9.j2

@@ -1,2 +0,0 @@
-[Service]
-ExecStartPost=/bin/sh -ec 'dnf needs-restarting -r | grep -q "Reboot is req.*" && shutdown -r +5 Rebooting after applying package updates || exit 0'

roles/base/templates/dnf-automatic-install.timer.j2

@@ -1,5 +1,5 @@
 [Timer]
 OnBootSec=
-OnCalendar= 2:00
+OnCalendar={{ base_redhat_dnf_automatic_timer }}
-RandomizedDelaySec=5m
+RandomizedDelaySec={{ base_redhat_dnf_automatic_timer_randomizer }}
 AccuracySec=1s